[FFmpeg-devel] [EXTREMELY IMPORTANT] [PLEASE DO NOT IGNORE] [PATCH] avfilter/framesync: do not pick AV_TIME_BASE for time base when not needed.

[Paul B Mahol]

On 2/2/20, Nicolas George <george at nsup.org> wrote:
> Paul B Mahol (12020-02-02):
>> Changing time base when all inputs have same time base seems strange
>> and excessive to me.
>
> This is true when the denominator is 500000, when it's 499999 and when
> it's 500001. Expending efforts just for 500000 is not efficient,
> especially since this one does not lead to a loss of precision.
>
>> Is there something wrong with my patch or you just prefer status quo?
>
> The current code seems more logical to me. Large round denominators are
> a sign that the time base was not really rational in the first place.

What about special code that checks all time-bases are same and keeping it?

Changing time-base is far from ideal solution in such scenario for any usecase.