[FFmpeg-devel] [PATCH 2/6] avcodec:v4l2_context: Remove NULL initialization

[Mark Thompson]

On 13/01/2020 04:11, Andriy Gelman wrote:
> From: Andriy Gelman <andriy.gelman at gmail.com>
> 
> Signed-off-by: Andriy Gelman <andriy.gelman at gmail.com>
> ---
>  libavcodec/v4l2_context.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
On 13/01/2020 04:11, Andriy Gelman wrote:> From: Andriy Gelman <andriy.gelman at gmail.com>
> 
> Before this commit s->avctx == NULL was used to infer that an encoder is
> being initialzed. Code readability has been improved by directly using
> !av_codec_is_decoder() instead.
> 
> Signed-off-by: Andriy Gelman <andriy.gelman at gmail.com>
> ---
>  libavcodec/v4l2_m2m.c     | 4 ++--
>  libavcodec/v4l2_m2m_enc.c | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
On 13/01/2020 04:11, Andriy Gelman wrote:> From: Andriy Gelman <andriy.gelman at gmail.com>
> 
> Before this commit v4l2_m2m used two different logging contexts (from
> V4L2m2mPriv and AVCodecContext). For consistency always use AVCodecContext.
> 
> Signed-off-by: Andriy Gelman <andriy.gelman at gmail.com>
> ---
>  libavcodec/v4l2_context.c |  2 +-
>  libavcodec/v4l2_m2m.c     | 18 +++++++++---------
>  2 files changed, 10 insertions(+), 10 deletions(-)
> 
On 13/01/2020 04:11, Andriy Gelman wrote:> From: Andriy Gelman <andriy.gelman at gmail.com>
> 
> Change pointer symbol position.
> 
> Signed-off-by: Andriy Gelman <andriy.gelman at gmail.com>
> ---
>  libavcodec/v4l2_m2m.c     | 10 +++++-----
>  libavcodec/v4l2_m2m_dec.c |  2 +-
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 

All four of these LGTM.  I did a little bit of testing and applied.

Thanks,

- Mark