[FFmpeg-devel] [PATCH 5/5] avformat/avc: support writting more than one sps/pps in ff_isom_write_avcc

[James Almer]

On 11/29/2017 9:58 PM, Michael Niedermayer wrote:
> On Tue, Nov 28, 2017 at 10:43:03PM -0300, James Almer wrote:
>> Addresses ticket #6864
>>
>> Signed-off-by: James Almer <jamrial at gmail.com>
>> ---
>> I don't have the h264 in isobmff spec at hand, so i just looked at what
>> the h264_mp4toannexb bsf does to handle more than one sps and pps and
>> worked with that.
>> If there's a pps limit it's not currently enforced, but adding it is
>> trivial. The sps limit i added is arbitrarily 2^5-1, as that's the
>> amount of bits available for it.
> 
> theres H264_MAX_PPS_COUNT and H264_MAX_SPS_COUNT

Exactly 5 and 8 bits each, so that's pretty much it. Thanks.

> 
> 
>>
>>  libavformat/avc.c | 50 +++++++++++++++++++++++++++++++++++++-------------
>>  1 file changed, 37 insertions(+), 13 deletions(-)
> 
> LGTM, someone should check it against the spec thhough

Pushed.