[FFmpeg-devel] [ogg] Respect AVERROR codes returned by ogg header parsing.

[Michael Niedermayer]

On Tue, Nov 28, 2017 at 02:17:21PM -0800, Dale Curtis wrote:
> Fixes bad parens in the above patch.
> 
> - dale
> 
> On Tue, Nov 28, 2017 at 2:03 PM, Dale Curtis <dalecurtis at chromium.org>
> wrote:
> 
> > Actually packet() was broken too, updated the patch to fix this case too.
> >
> > - dale
> >
> > On Tue, Nov 28, 2017 at 1:41 PM, Dale Curtis <dalecurtis at chromium.org>
> > wrote:
> >
> >> Fixes ticket #6804. All of the ogg header parsers may return
> >> standard AVERROR codes; these return values should not be
> >> treated as success.
> >>
> >> Signed-off-by: Dale Curtis <dalecurtis at chromium.org>
> >>
> >>
> >>
> >

>  oggdec.c |   10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 07e15d08be7fcce839206cdd699eea804b1520ff  fix_ogg_v3.patch
> From 8d3b21ab59d835430f057cfb40a63318b25e7014 Mon Sep 17 00:00:00 2001
> From: Dale Curtis <dalecurtis at chromium.org>
> Date: Tue, 28 Nov 2017 13:40:20 -0800
> Subject: [PATCH] Respect AVERROR codes returned by ogg parsers.
> 
> Fixes ticket #6804. All of the ogg header and packet parsers may
> return standard AVERROR codes; these return values should not be
> treated as success.
> 
> Signed-off-by: Dale Curtis <dalecurtis at chromium.org>
> ---
>  libavformat/oggdec.c | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)

This breaks converting of this:
./ffmpeg -i bgc.sub.dub.ogm -vf subtitles=bgc.sub.dub.ogm -an  file.avi

https://samples.ffmpeg.org/ogg/bgc.sub.dub.ogm

[...]


-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you think the mosad wants you dead since a long time then you are either
wrong or dead since a long time.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171129/4de2909c/attachment.sig>