[FFmpeg-devel] [PATCH] configure: fix module dependencies on zlib

[James Almer]

On 11/20/2017 2:34 PM, Michael Niedermayer wrote:
> On Sun, Nov 19, 2017 at 04:00:11PM -0300, James Almer wrote:
>> select should not be used with external libraries. It's mean to soft
>> enable internal modules/features.
>>
>> Signed-off-by: James Almer <jamrial at gmail.com>
>> ---
>>  configure | 48 ++++++++++++++++++++++++++----------------------
>>  1 file changed, 26 insertions(+), 22 deletions(-)
> 
> btw, is all the *suggest= zlib stuff correct ?
> 
> at least in the past configure could not handle a mix of
> dependancies which turned targets on and which turned sources off
> as the order in which they where executed resilted in different
> outcomes

'foo_suggest="bar"' nowadays is basically the same as doing 'enabled foo
&& enable_weak bar && enabled bar && append foo_extralibs
$bar_extralibs'. It does not disable foo under any circumstances.

enable_weak can't enable what was hard disabled, and zlib being
autodetected will be either hard enabled or hard disabled by the
automated check or by a command line option by the time dependency
checks are made.