[FFmpeg-devel] [PATCH] avformat/movenc: correct ImageDescription depth for v210 v410

[Michael Niedermayer]

On Thu, Nov 16, 2017 at 06:27:38PM -0500, Dave Rice wrote:
> 
> > On Nov 16, 2017, at 6:08 PM, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
> > 
> > 2017-11-16 17:54 GMT+01:00 Dave Rice <dave at dericed.com>:
> > 
> >> +    if (track->mode == MODE_MOV && track->par->codec_id == AV_CODEC_ID_V410)
> >> +        avio_wb16(pb, 0x18);
> >> +    else if (track->mode == MODE_MOV && track->par->codec_id == AV_CODEC_ID_V210)
> >> +        avio_wb16(pb, 0x18);
> > 
> > It appears you can merge the two cases.
> 
> The patch is updated with merged cases below.
> 
> > Or maybe patch bits_per_coded_sample in the encoder…
> 
> 
> With Apple’s TN2162 there doesn’t appear to be a reliable relationship between the bits_per_coded_sample and what the ImageDescription depth value should be for the uncompressed yuv formats. TN2162 simply lists what the depth value should be and this patch corrects the few instances, where ffmpeg’s behavior doesn’t correlate to what TN2162 defines.
> 
> 
> From cfa5b2cd959154f2896a9557d9ca2ed2d2d3834e Mon Sep 17 00:00:00 2001
> From: Dave Rice <dave at dericed.com>
> Date: Thu, 16 Nov 2017 11:53:32 -0500
> Subject: [PATCH 2/2] avformat/movenc: correct ImageDescription depth for v210
>  v410

please add a fate test
LGTM if its tested

thx
[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Does the universe only have a finite lifespan? No, its going to go on
forever, its just that you wont like living in it. -- Hiranya Peiri
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171117/54d089c8/attachment.sig>