[FFmpeg-devel] [PATCH] avutil/crc: use ff_thread_once at av_crc_get_table

Muhammad Faiz mfcc64 at gmail.com
Sun Nov 12 15:28:25 EET 2017


On Wed, Nov 1, 2017 at 12:37 AM, Muhammad Faiz <mfcc64 at gmail.com> wrote:
> On Mon, Oct 30, 2017 at 8:07 PM, Michael Niedermayer
> <michael at niedermayer.cc> wrote:
>> On Mon, Oct 30, 2017 at 02:14:35PM +0700, Muhammad Faiz wrote:
>>> On Tue, Oct 24, 2017 at 4:31 PM, Muhammad Faiz <mfcc64 at gmail.com> wrote:
>>> > Fix tsan warnings.
>>> >
>>> > Signed-off-by: Muhammad Faiz <mfcc64 at gmail.com>
>>> > ---
>>> >  libavutil/crc.c | 49 +++++++++++++++++++++++++++++--------------------
>>> >  1 file changed, 29 insertions(+), 20 deletions(-)
>>>
>>> Ping.
>>
>> I assume james patch is faster than both ?
>>
>> If this code is never run in speed relevant loops then your solution is
>> better. Otherwise i think james patch is better
>
> I guess the common usage is to call av_crc() which is far more
> computationally intensive after calling av_crc_get_table().

Ping.
I'm going to apply this tomorrow.

Thank's.


More information about the ffmpeg-devel mailing list