[FFmpeg-devel] [PATCH] Added additional note to fate.texi to describe the importance of not checking out files from git with core.autocrlf set to true

[Hendrik Leppkes]

On Sat, Apr 22, 2017 at 9:07 PM, Aaron Levinson <alevinsn at aracnet.com> wrote:
>
>
> On 4/22/2017 2:16 AM, Clément Bœsch wrote:
>>
>> On Fri, Apr 21, 2017 at 04:48:27PM -0700, Aaron Levinson wrote:
>> [...]
>>>
>>> diff --git a/doc/fate.texi b/doc/fate.texi
>>> index 7a96c25..f3b8c0c8 100644
>>> --- a/doc/fate.texi
>>> +++ b/doc/fate.texi
>>> @@ -77,6 +77,16 @@ FATE_SAMPLES=fate-suite/ make fate
>>>  @float NOTE
>>>  Do not put a '~' character in the samples path to indicate a home
>>>  directory. Because of shell nuances, this will cause FATE to fail.
>>> +
>>> +In addition, FATE will fail if files are checked out from git such
>>> +that @kbd{@key{CR}@key{LF}} is used for line endings.  This will occur
>>> +on Windows when git is installed using the default options, because
>>> +that causes git's @var{core.autocrlf} setting to be set to
>>> + at option{true}.  Make sure to set @var{core.autocrlf} to @option{input}
>>> +or @option{false}, or, in the case that the repository has already
>>> +been cloned, it is possible to get past this by executing the
>>> +following command in the top-level ffmpeg directory: @command{find
>>> +-name '*.h' -type f | xargs dos2unix}.
>>>  @end float
>>>
>>
>> This is documented in doc/git-howto.texi, isn't it?
>
>
> Yes it is, but just because it can be found elsewhere in the documentation
> doesn't mean there isn't benefit to having a fallback elsewhere in the
> documentation.

Can't we just make it point there, instead of explaining it again?

- Hendrik