[FFmpeg-devel] [PATCH]lsws/utils: Make gray10 and gray12 full-scale like gray8 and gray16

[Carl Eugen Hoyos]

2017-04-13 0:09 GMT+02:00 Ronald S. Bultje <rsbultje at gmail.com>:
> Hi,
>
> On Tue, Apr 4, 2017 at 8:01 AM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
>
>> On Tue, Apr 4, 2017 at 6:33 AM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
>>
>>> I believe attached patch makes FFmpeg a little more consistent with
>>> itself.
>>
>>
>> Looks like it, yes.
>>
>> This patch does expose a bug we've discussed before though. Since the
>> return value of handle_jpeg() is or()'ed into src_range and dst_range, it
>> overwrites an explicit zero range requested by the user. So If my input is
>> a h264 grayscale file with color_range in VUI explicitly set to MPEG-range,
>> I believe swscale does the wrong thing and the output color will be
>> distorted.
>>
>> (This is orthogonal to your patch, but may be worth of a trac ticket.)
>
> Was the ticket created? This is a fairly important bug.

Not by me (I don't even know how to reproduce).

Carl Eugen