[FFmpeg-devel] [PATCH 2/2] Add experimental support for Opus in ISO BMFF (MP4)

[Michael Niedermayer]

On Fri, Apr 07, 2017 at 04:29:36PM +1200, Matthew Gregan wrote:
> At 2017-04-05T20:43:21-0300, James Almer wrote:
> > > +    /* OpusSpecificBox size plus magic for Ogg OpusHead header. */
> > > +    size = atom.size + 16;
> > 
> > This should be 8. "OpusHead" is not 16 bytes.
> > 
> > > +    avio_read(pb, st->codecpar->extradata + 9, size - 17);
> > 
> > Same, this should be size - 9.
> 
> Oops, silly mistake there.  Thanks for the feedback!  Updated patch attached.

>  mov.c |   49 +++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 49 insertions(+)
> 199c01f1982f698e42dcaed7213a51fddca5f040  0002-Add-experimental-demuxing-support-for-Opus-in-ISO-BM.patch
> From 9ff591b9ae6a50ea3326e7374f800f7dd12eeef2 Mon Sep 17 00:00:00 2001
> From: Matthew Gregan <kinetik at flim.org>
> Date: Thu, 16 Mar 2017 14:17:21 +1300
> Subject: Re: [PATCH 2/2] Add experimental demuxing support for Opus in ISO BMFF
>  (MP4).
> 
> Based on the draft spec at http://vfrmaniac.fushizen.eu/contents/opus_in_isobmff.html

applied

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170411/0e85402d/attachment.sig>