[FFmpeg-devel] [PATCH] mjpegenc: enable optimal huffman coding by default

[Rostislav Pehlivanov]

On 5 April 2017 at 20:05, Michael Niedermayer <michael at niedermayer.cc>
wrote:

> On Tue, Apr 04, 2017 at 04:10:39PM +0200, Michael Niedermayer wrote:
> > On Tue, Apr 04, 2017 at 03:59:28PM +0200, Michael Niedermayer wrote:
> > > On Tue, Apr 04, 2017 at 11:00:23AM +0100, Rostislav Pehlivanov wrote:
> > > > On 4 April 2017 at 02:54, Michael Niedermayer <michael at niedermayer.cc
> >
> > > > wrote:
> > > >
> > > > > On Mon, Apr 03, 2017 at 10:31:27PM +0100, Rostislav Pehlivanov
> wrote:
> > > > > > As it gives excellent encoding gains at an insignificant speed
> increase
> > > > > > and passes fate without problems, it should now be safe to
> enable by
> > > > > > default.
> > > > >
> > > > > Still breaks slice threading
> > > > >
> > > > > both
> > > > > Assertion n <= 31 && value < (1U << n) failed at
> libavcodec/put_bits.h:157
> > > > >
> > > > > and
> > > > > Assertion (header_bits & 7) == 0 failed at
> libavcodec/mjpegenc_common.c:
> > > > > 541
> > > > >
> > > > > occur with
> > > > > ./ffmpeg -y -i ~/fatesamples/fate/fate-suite/lena.pnm  -vf scale
> -strict
> > > > > -1  -threads 2 -thread_type slice test.jpg
> > > > >
> > > > > randomly
> > > > >
> > > > > also ive seen it not trigger an assert on repeating the command
> > > > >
> > > > > [...]
> > > > > --
> > > > > Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC7
> 87040B0FAB
> > > > >
> > > > > You can kill me, but you cannot change the truth.
> > > > >
> > > > > _______________________________________________
> > > > > ffmpeg-devel mailing list
> > > > > ffmpeg-devel at ffmpeg.org
> > > > > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> > > > >
> > > > >
> > > > Sent a patch meant to be applied before this patch to disable it
> with AMV
> > > > and slice threads, should fix this issue.
> > >
> > > The failing case doesnt use AMV
> > > and i double checked, i had all 3 patches applied when i tested
> > > yestarday
> >
> > wait, i just saw you posted a new patch today, i havnt tried that
> > will do
>
> tried, seems to work
>
> [...]
>
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Awnsering whenever a program halts or runs forever is
> On a turing machine, in general impossible (turings halting problem).
> On any real computer, always possible as a real computer has a finite
> number
> of states N, and will either halt in less than N cycles or never halt.
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>
Thanks for the review, pushed to master.