[FFmpeg-devel] [PATCH] avfilter: implement vf_remap_frac

[Nicolas George]

L'octidi 18 germinal, an CCXXV, Daniel Oberhoff a écrit :
> what do you propose?

I personally have no objection underscores in filter names.
Spaceswereinventedforareason. And we already have a few filters with
underscores in them.

On the other hand, the patch looks like a big copy-paste of the original
vf_remap with a few changes and some extra features (slice threading,
high bit depth), and that is a big no. I think the features should be
implemented in the original filter. The normal and 16 versions of the
functions also looks nearly identical and should be factored.

Also, it is missing documentation.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170407/30bce9ce/attachment.sig>