[FFmpeg-devel] [PATCH 5/6] x86/simple_idct: add explicit sse2 simple_idct_put/add versions.

[Michael Niedermayer]

On Tue, Apr 04, 2017 at 12:48:17PM -0400, Ronald S. Bultje wrote:
> These use the mmx IDCT, but sse2 put/add_pixels_clamped implementations.
> This way we don't need to use the ff_put/add_pixels_clamped function
> pointers.
> ---
>  libavcodec/x86/idctdsp_init.c | 10 ++++++++++
>  libavcodec/x86/simple_idct.c  | 15 +++++++++++++--
>  libavcodec/x86/simple_idct.h  |  3 +++
>  3 files changed, 26 insertions(+), 2 deletions(-)
> 
> diff --git a/libavcodec/x86/idctdsp_init.c b/libavcodec/x86/idctdsp_init.c
> index bcf7e5b..579c5e7 100644
> --- a/libavcodec/x86/idctdsp_init.c
> +++ b/libavcodec/x86/idctdsp_init.c
> @@ -87,6 +87,16 @@ av_cold void ff_idctdsp_init_x86(IDCTDSPContext *c, AVCodecContext *avctx,
>      }
>  
>      if (ARCH_X86_64 && avctx->lowres == 0) {
> +        if (!high_bit_depth &&

> +            avctx->lowres == 0 &&

this looks redundant

otherwise should be ok

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170404/0f15056d/attachment.sig>