[FFmpeg-devel] [PATCH 2/5] avcodec/vc1: optimize block functions

Michael Niedermayer michaelni at gmx.at
Sat Feb 28 17:11:41 CET 2015


On Wed, Feb 25, 2015 at 12:28:45AM +0800, zhaoxiu.zeng wrote:
> 在 2015/2/19 2:12, Michael Niedermayer 写道:
> > On Sat, Feb 14, 2015 at 10:56:28PM +0800, zhaoxiu.zeng wrote:
> >> From 960eca51e6e65e6969f7d829e29ddc2387420733 Mon Sep 17 00:00:00 2001
> >> From: Zeng Zhaoxiu <zhaoxiu.zeng at gmail.com>
> >> Date: Sat, 14 Feb 2015 19:46:51 +0800
> >> Subject: [PATCH 2/5] avcodec/vc1: optimize block functions
> > 
> > This patch breaks make fate:
> > also please include benchmark values
> > 
> > --- ./tests/ref/fate/mss2-wmv   2015-02-12 16:53:42.138771890 +0100
> > +++ tests/data/fate/mss2-wmv    2015-02-18 19:10:41.449866314 +0100
> > @@ -27,11 +27,11 @@
> >  0,         31,         31,        1,   230400, 0x18a2f97a
> >  0,         32,         32,        1,   230400, 0xf9e82961
> >  0,         33,         33,        1,   230400, 0x57a8e9e8
> > -0,         34,         34,        1,   230400, 0xdef6fd66
> > -0,         35,         35,        1,   230400, 0xc7d923a9
> > -0,         36,         36,        1,   230400, 0x08bb41ee
> > -0,         37,         37,        1,   230400, 0x43ccbd29
> > -0,         38,         38,        1,   230400, 0x46666ee3
> > +0,         34,         34,        1,   230400, 0xbd60fd5a
> > +0,         35,         35,        1,   230400, 0x289b2391
> > +0,         36,         36,        1,   230400, 0x8d5a4205
> > +0,         37,         37,        1,   230400, 0xbed1bcb6
> > +0,         38,         38,        1,   230400, 0x24086ea2
> >  0,         39,         39,        1,   230400, 0xbfd2ef29
> >  0,         40,         40,        1,   230400, 0x6504545f
> >  0,         41,         41,        1,   230400, 0x8fb86901
> > @@ -40,25 +40,25 @@
> >  0,         44,         44,        1,   230400, 0xf808106b
> >  0,         45,         45,        1,   230400, 0x34150020
> >  0,         46,         46,        1,   230400, 0x50fdfe89
> > -0,         47,         47,        1,   230400, 0x920b7708
> > +0,         47,         47,        1,   230400, 0xe8287631
> >  0,         48,         48,        1,   230400, 0xed64fcc4
> >  0,         49,         49,        1,   230400, 0x6291a170
> >  0,         50,         50,        1,   230400, 0x20524643
> > -0,         51,         51,        1,   230400, 0x92aafecd
> > +0,         51,         51,        1,   230400, 0x5e9efe62
> >  0,         52,         52,        1,   230400, 0xf00ee14d
> >  0,         53,         53,        1,   230400, 0xfa3113ea
> >  0,         54,         54,        1,   230400, 0x99c06df1
> >  0,         55,         55,        1,   230400, 0x625c6918
> > -0,         56,         56,        1,   230400, 0xb277b25e
> > +0,         56,         56,        1,   230400, 0xeb34b22e
> >  0,         57,         57,        1,   230400, 0x2e913006
> >  0,         58,         58,        1,   230400, 0x3f6f1d99
> >  0,         59,         59,        1,   230400, 0x100ab60f
> > -0,         60,         60,        1,   230400, 0x9b73d0bf
> > +0,         60,         60,        1,   230400, 0xe21acfc4
> >  0,         61,         61,        1,   230400, 0xda0df2ce
> >  0,         62,         62,        1,   230400, 0x67f7ca24
> >  0,         63,         63,        1,   230400, 0xbde9b3d0
> >  0,         64,         64,        1,   230400, 0x92e14d07
> > -0,         65,         65,        1,   230400, 0x9426c3d9
> > +0,         65,         65,        1,   230400, 0xa584c3c4
> >  0,         66,         66,        1,   230400, 0x6104be70
> >  0,         67,         67,        1,   230400, 0xc4d1078a
> >  0,         68,         68,        1,   230400, 0x89426a42
> > @@ -67,35 +67,35 @@
> >  0,         71,         71,        1,   230400, 0x4249b8c6
> >  0,         72,         72,        1,   230400, 0x4b88cad3
> >  0,         73,         73,        1,   230400, 0x76af545d
> > -0,         74,         74,        1,   230400, 0xfe47e3c4
> > +0,         74,         74,        1,   230400, 0xb165e37d
> >  0,         75,         75,        1,   230400, 0xa2e0e721
> >  0,         76,         76,        1,   230400, 0xde974a42
> > -0,         77,         77,        1,   230400, 0x87bf38ba
> > +0,         77,         77,        1,   230400, 0x3dad37cc
> >  0,         78,         78,        1,   230400, 0xd52318fd
> >  0,         79,         79,        1,   230400, 0x0bbb1526
> > -0,         80,         80,        1,   230400, 0xa22c5e5e
> > +0,         80,         80,        1,   230400, 0xe85b5e88
> >  0,         81,         81,        1,   230400, 0x4532c5d2
> >  0,         82,         82,        1,   230400, 0x88b560ec
> > -0,         83,         83,        1,   230400, 0xcee9d9c9
> > +0,         83,         83,        1,   230400, 0xeddad96d
> >  0,         84,         84,        1,   230400, 0x0429358f
> > -0,         85,         85,        1,   230400, 0xf18a9b98
> > -0,         86,         86,        1,   230400, 0x63f7a12c
> > -0,         87,         87,        1,   230400, 0x98635515
> > +0,         85,         85,        1,   230400, 0xaee09b6d
> > +0,         86,         86,        1,   230400, 0xce98a02b
> > +0,         87,         87,        1,   230400, 0x127654f4
> >  0,         88,         88,        1,   230400, 0x36affebc
> >  0,         89,         89,        1,   230400, 0xd8c19629
> > -0,         90,         90,        1,   230400, 0x9ef5344d
> > -0,         91,         91,        1,   230400, 0x545668dc
> > -0,         92,         92,        1,   230400, 0x50e65e74
> > -0,         93,         93,        1,   230400, 0xe3258be3
> > -0,         94,         94,        1,   230400, 0xeb479e1b
> > -0,         95,         95,        1,   230400, 0x91894243
> > -0,         96,         96,        1,   230400, 0x3c5660fc
> > -0,         97,         97,        1,   230400, 0xf0c35673
> > +0,         90,         90,        1,   230400, 0xfaac34dd
> > +0,         91,         91,        1,   230400, 0x552568d9
> > +0,         92,         92,        1,   230400, 0xc0015fad
> > +0,         93,         93,        1,   230400, 0x50778be0
> > +0,         94,         94,        1,   230400, 0x5d569f88
> > +0,         95,         95,        1,   230400, 0xe2c5424a
> > +0,         96,         96,        1,   230400, 0x72d6631f
> > +0,         97,         97,        1,   230400, 0x64e656b2
> >  0,         98,         98,        1,   230400, 0x552832e8
> >  0,         99,         99,        1,   230400, 0x1970f2b1
> > -0,        100,        100,        1,   230400, 0x812d4c91
> > +0,        100,        100,        1,   230400, 0x464549e2
> >  0,        101,        101,        1,   230400, 0xa3fbd4ef
> > -0,        102,        102,        1,   230400, 0x486f9649
> > +0,        102,        102,        1,   230400, 0xc44493bc
> >  0,        103,        103,        1,   230400, 0x850f315a
> > -0,        104,        104,        1,   230400, 0xc18ec66b
> > -0,        105,        105,        1,   230400, 0xc9ef266e
> > +0,        104,        104,        1,   230400, 0xa3a4c41c
> > +0,        105,        105,        1,   230400, 0x0f5523c7
> > Test mss2-wmv failed. Look at tests/data/fate/mss2-wmv.err for details.
> > make: *** [fate-mss2-wmv] Error 1
> > make: *** Waiting for unfinished jobs....
> > 
> > [...]
> > 
> > 
> > 
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel at ffmpeg.org
> > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> > 
> From f55454c496ff8d372528dcc61536f3a575de3c4b Mon Sep 17 00:00:00 2001
> From: Zeng Zhaoxiu <zhaoxiu.zeng at gmail.com>
> Date: Wed, 25 Feb 2015 00:04:20 +0800
> Subject: [PATCH 1/1] vcodec/vc1: optimize block functions
> 
> I tested on fedora21-x86_64 (running on vmware workstation, windows7 32bits).
> Follwing are the results:

ive split some changes out and applied them.
Please split the rest similarly and resubmit in cleanly split patches
if possible with benchmark scores for each

Thanks!

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150228/63d86863/attachment.asc>


More information about the ffmpeg-devel mailing list