[FFmpeg-devel] [PATCH] movenc: Write 'colr' box correctly for MP4

[Clément Bœsch]

On Thu, Feb 26, 2015 at 06:15:30PM +0100, Michael Niedermayer wrote:
> On Thu, Feb 26, 2015 at 04:54:02PM +0100, Clément Bœsch wrote:
> > On Thu, Feb 26, 2015 at 01:53:13PM +0000, Derek Buitenhuis wrote:
> > > On 2/26/2015 1:50 PM, Clément Bœsch wrote:
> > > > If the option is set by default, you don't want to warn for no reason.
> > > 
> > > It's not set by default. That patch never went in.
> > > 
> > 
> > Ah, my bad.
> > 
> > > I don't believe silently not writing it is a valid approach. Then
> > > again I think setting a default movflag like that instead of
> > > changing the option is also stupid.
> > 
> > Well, breaking API on purpose when easily avoidable is kind of stupid too.
> > 
> > You can also just deprecate the current flag and add yours. The point is
> > to not make the option disappear because it will break callers. Changing
> > the behaviour (enabling by default / making the old option void) is fine,
> > breaking the API (removing the option) not so much.
> 
> the option is in there since a month and was in no release so
> IMHO if people feel strongly about it then i guess simply replacing
> the option might be acceptable

Oh, I completely missed that. Then yeah, sure. Sorry for the noise.

[...]

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150226/36147fef/attachment.asc>