[FFmpeg-devel] [PATCH] movenc: Write 'colr' box correctly for MP4

Michael Niedermayer michaelni at gmx.at
Thu Feb 26 18:16:53 CET 2015


On Thu, Feb 26, 2015 at 01:47:01PM +0000, Derek Buitenhuis wrote:
> This also restricts it to MOV and MP4, since it is only
> defined for those formats.
> 
> Signed-off-by: Derek Buitenhuis <derek.buitenhuis at gmail.com>
> ---
>  libavformat/movenc.c | 29 +++++++++++++++++++++++------
>  1 file changed, 23 insertions(+), 6 deletions(-)

LGTM (the warning would have to be removed though if the specific
codepath would be enabled by default)

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150226/3dee2d86/attachment.asc>


More information about the ffmpeg-devel mailing list