[FFmpeg-devel] [PATCH] movenc: Write 'colr' box correctly for MP4

[Clément Bœsch]

On Thu, Feb 26, 2015 at 01:53:13PM +0000, Derek Buitenhuis wrote:
> On 2/26/2015 1:50 PM, Clément Bœsch wrote:
> > If the option is set by default, you don't want to warn for no reason.
> 
> It's not set by default. That patch never went in.
> 

Ah, my bad.

> I don't believe silently not writing it is a valid approach. Then
> again I think setting a default movflag like that instead of
> changing the option is also stupid.

Well, breaking API on purpose when easily avoidable is kind of stupid too.

You can also just deprecate the current flag and add yours. The point is
to not make the option disappear because it will break callers. Changing
the behaviour (enabling by default / making the old option void) is fine,
breaking the API (removing the option) not so much.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150226/fac6b940/attachment.asc>