[FFmpeg-devel] [PATCH 2/4] avcodec/a64multienc: don't set incorrect packet size

[Michael Niedermayer]

On Sun, Feb 22, 2015 at 09:58:09PM +0100, Andreas Cadhalpun wrote:
> Hi,
> 
> increasing the packet size without enlarging the packet buffer can't
> be correct...
> This seems to be broken since [1].
> 
> Best regards,
> Andreas
> 
> 1: https://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=7340008f18dc7d1557efbf5a331c9452913f7f61



>  a64multienc.c |    3 ---
>  1 file changed, 3 deletions(-)
> c55a02cc996cda0747e83d2ecc07c6c40c986f03  0002-avcodec-a64multienc-don-t-set-incorrect-packet-size.patch
> From c1bc01a84654df6a0e9ec4ea62f95920bfb80e32 Mon Sep 17 00:00:00 2001
> From: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
> Date: Sun, 22 Feb 2015 20:45:19 +0100
> Subject: [PATCH 2/4] avcodec/a64multienc: don't set incorrect packet size
> 
> This fixes invalid reads of the packet buffer in av_dup_packet.

This leaves the packet size wrong for mc_use_5col = 0
The quoted commit broke the size calculation quite completely
ill try to fix it

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150223/fb6a5be0/attachment.asc>