[FFmpeg-devel] tools: crypto_bench: Added support for Twofish

[supraja reddy]

Hello,

I have made the changes as suggested by Giorgio. Please let me know if any
further changes required.

Thanks,
Supraja


On Wed, Feb 18, 2015 at 10:52 PM, Giorgio Vazzana <mywing81 at gmail.com>
wrote:

> Hi,
>
> 2015-02-14 11:12 GMT+01:00 Giorgio Vazzana <mywing81 at gmail.com>:
> > Hi,
> >
> > 2015-02-14 9:33 GMT+01:00 supraja reddy <supraja0493 at gmail.com>:
> >> Hello,
> >>
> >> I have added the necessary functions for twofish in crypto_bench.
> >> A note, there is no twofish implementation in openssl library but since
> the
> >> code demands that all the libraries have the impl, i have introduced a
> >> dummy function.
> >
> > I know this was initially my suggestion, but looking now at the code I
> > see that maybe we could use the IMPL() macro instead of the IMPL_ALL()
> > macro in order to exclude 'crypto'. This should simplify the patch.
> >
> > I'll give it a look tomorrow hopefully, but of course let's see if
> > others have comments.
>
> what about something like the following code? You won't need to add a
> dummy function or insert a check inside run_implementation():
>
> @@ -398,6 +398,9 @@ struct hash_impl implementations[] = {
>      IMPL_ALL("AES-128",    aes128,    "crc:ff6bc888")
>      IMPL_ALL("CAMELLIA",   camellia,  "crc:7abb59a7")
>      IMPL_ALL("CAST-128",   cast128,   "crc:456aa584")
> +    IMPL(lavu,     "TWOFISH", twofish, "crc:9edbd5c1")
> +    IMPL(gcrypt,   "TWOFISH", twofish, "crc:9edbd5c1")
> +    IMPL(tomcrypt, "TWOFISH", twofish, "crc:9edbd5c1")
>  };
>
> Giorgio Vazzana
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cbf.patch
Type: text/x-patch
Size: 3036 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150221/70813788/attachment.bin>