[FFmpeg-devel] [PATCH] x86/doc/Makefile: DBG=1 to preprocess external asm

[Christophe Gisquet]

Hi,

2015-02-17 20:06 GMT+01:00 James Almer <jamrial at gmail.com>:
> $ make libavcodec/x86/dcadsp.o DBG=0

OK, it's mainly a matter of documentation then here, as just having
DBG defined is fine. I'm not sure of the makefile syntax if DBG=1 is
what is really wanted.

> YASM    libavcodec/x86/dcadsp.dbg.asm
> YASM    libavcodec/x86/dcadsp.o
> STRIP   libavcodec/x86/dcadsp.o
> rm libavcodec/x86/dcadsp.dbg.asm

Huh, a rm command isn't issued in the rule...

On the other hand, running make with debugging states:
Successfully remade target file `libavcodec/x86/dcadsp.o'.
Removing intermediate files...
rm libavcodec/x86/dcadsp.dbg.asm

So, in a way, the above is quite ok: no need to keep
libavcodec/x86/dcadsp.dbg.asm around if compilation was ok.

But if you run the command a 2nd time, it does keep it around :(
And it shouldn't even attempt this because compilation is succesful.

I think this a dependency rule issue for the .dbg.asm file

But even with the attached file, it still rebuilds it an additional
time. But third time is the charm, as it stops rebuilding it...

> $ rm libavcodec/x86/dcadsp.o
>
> $ make libavcodec/x86/dcadsp.o
> YASM    libavcodec/x86/dcadsp.dbg.asm

This seems fixed with the attached patch.

But I wonder if a dependency rule is really needed, as I can see it
causing issues... (does it depend on .asm or .dbg.asm etc)

So I don't think we there yet.

-- 
Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Makefile-improve-DBG-option-for-asm.patch
Type: text/x-diff
Size: 1169 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150218/68ed7312/attachment.bin>