[FFmpeg-devel] [PATCH 1/7] avformat/rtpdec_ac3: add AC3 RTP depacketization

[Gilles Chanteperdrix]

On Thu, Feb 12, 2015 at 10:07:39PM +0100, Thomas Volkert wrote:
> >+        if (nr_frames > 1) {
> >+            av_log(ctx, AV_LOG_ERROR,
> >+                   "Unimplemented multiple AC3 frames per packet\n");
> 
> You could use avpriv_report_missing_feature() here.

I am not sure that the case where there are multiple frames in one
packet is not already working: frames are concatenated without not
headers, so the full AC3 parser should be able to split the packet
in multiple frames right ? Unfortunately, I do not have an example
using this feature.


> >+        if (nr_frames > 1) {
> >+            av_log(ctx, AV_LOG_ERROR,
> >+                   "Unimplemented multiple AC3 frames per packet\n");
> 
> You could use avpriv_report_missing_feature() here.

I am not sure that the case where there are multiple frames in one
packet is not already working: frames are concatenated without not
headers, so the full AC3 parser should be able to split the packet
in multiple frames right ? Unfortunately, I do not have an example
using this feature.

> 
> Do you see any use for the optional SDP parameter?
> If yes, you could add an AC3 specific parser for SDP line and link it as
> ".parse_sdp_a_line" line here.

Which optional SDP parameter? channels,ptime,maxptime ?

> What do you think about a packetizer as counterpart?

Currently, I am using live555 as an RTSP server. I did not check
ffmpeg documentation to see how to run an RTSP server. I will check.

-- 
					    Gilles.