[FFmpeg-devel] [PATCH] ffprobe: Force string_validation to int type, its accessed via AVOption as int

[Michael Niedermayer]

On Mon, Feb 09, 2015 at 01:44:43AM +0100, Clément Bœsch wrote:
> On Fri, Feb 06, 2015 at 10:10:22PM +0100, Michael Niedermayer wrote:
> > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > ---
> >  ffprobe.c |    3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/ffprobe.c b/ffprobe.c
> > index d352bb6b..8617c96 100644
> > --- a/ffprobe.c
> > +++ b/ffprobe.c
> > @@ -294,7 +294,8 @@ typedef enum {
> >      WRITER_STRING_VALIDATION_FAIL,
> >      WRITER_STRING_VALIDATION_REPLACE,
> >      WRITER_STRING_VALIDATION_IGNORE,
> > -    WRITER_STRING_VALIDATION_NB
> > +    WRITER_STRING_VALIDATION_NB,
> > +    WRITER_STRING_VALIDATION_FORCE_ENUM_TO_INT_TYPE= 0x76543210,
> >  } StringValidation;
> >  
> 
> I prefer the int approach you originally proposed. This hack makes me
> quite uncomfortable, and the idea of having it all over the code base as
> well.

perfectly fine with me as well, saste i think you preferred above?
or did i misunderstand ?

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150209/435585f9/attachment.asc>