[FFmpeg-devel] [PATCH 7/7] atrac3plus: Prevent array out-of-bounds

[Timothy Gu]

Actually GCC is too dumb. There is literally no way to "fix" this in a
clean way. Patch dropped.

On Fri Feb 06 2015 at 7:57:33 PM Timothy Gu <timothygu99 at gmail.com> wrote:

> On Fri Feb 06 2015 at 7:55:31 PM Timothy Gu <timothygu99 at gmail.com> wrote:
>
>> On Fri Feb 06 2015 at 7:44:23 PM Michael Niedermayer <michaelni at gmx.at>
>> wrote:
>>
>>> On Fri, Feb 06, 2015 at 07:32:56AM +0000, Timothy Gu wrote:
>>> > On Thu Feb 05 2015 at 11:07:01 PM Timothy Gu <timothygu99 at gmail.com>
>>> wrote:
>>> >
>>> > > (num_quant_units - 1) is later used as an index to
>>> atrac3p_qu_to_subband,
>>> > > which only has 32 elements (i.e. maximum of num_quant_units is 32).
>>> > > ---
>>> > >  libavcodec/atrac3plus.c | 2 +-
>>> > >  1 file changed, 1 insertion(+), 1 deletion(-)
>>> > >
>>> >
>>> > Note that this doesn't actually fix any problem else than a GCC
>>> warning.
>>>
>>> when i read the commit message it sounded like it fixes a serious
>>> bug ...
>>> also the exact warning which is fixed could be mentioned in the
>>> commit message
>>>
>>
>> Yeah I've been meant to add my second mail to the commit message, but
>> haven't found the time to use Git yet.
>>
>
> Actually I misread the warning message (GCC is smarter than I thought).
> New patch incoming.
>
> Timothy
>