[FFmpeg-devel] [PATCH 2/3] x86/hevcdsp: add ff_hevc_sao_edge_filter_8_{ssse3, avx2}

[Christophe Gisquet]

Hi,

2015-02-06 11:07 GMT+01:00 Hendrik Leppkes <h.leppkes at gmail.com>:
> I looked into the MSVC 64bit failure from this patch, and from what I
> can tell doing this doesn't work:
> movsx      a_strideq, byte [pb_eo+eoq*4+1]
>
> I'm not entirely sure on the specifics why it breaks however..
> But all I could find suggests that you should load the table address
> into a reg first, and then use that reg for the address computation.
>
> For some reason, the non-WIN64 version does just this, but the WIN64
> version does not.
> Any particular reason for this difference?

So I infer from those last 2 sentences it is a link failure. Indeed, I
did observe that issue of mingw64 (or whatever you call that) being
fine with this RIP addressing not being respected, but MSVC not.

So yes, an intermediate reg is needed, and we can't save that indirection.

Could you test the attached patch? Beware, it's on a tree having the
patch, but I'm not completely sure it will apply fine.

-- 
Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-x86-hevc_sao-fix-loading-of-RIP-address.patch
Type: text/x-diff
Size: 2437 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150206/d55f4233/attachment.bin>