[FFmpeg-devel] [PATCH] avcodec/nvenc: De-compensate aspect ratio compensation of DVD-like content.

[Philip Langdale]

On Wed, 04 Feb 2015 21:13:57 +0100
Timo Rothenpieler <timo at rothenpieler.org> wrote:

> > Could I get a proper review on this? I'd like to believe that we
> > have a consensus that, independent of whether we think there's
> > merit in this compensation logic, it shouldn't exist in a single
> > encoder, out of step with all the other encoders in ffmpeg.
> > 
> > Thanks,
> 
> It looks good to merge for me, i haven't had time to test this issue
> myself yet, but it definitely should behave like all other encoders
> do. If Nvidia ever changes the behaviour of this(So it would suddenly
> work as it should in a new driver release), an option do disable the
> compensation would be nice to have, so users aren't stuck with the
> then broken compensation.

I'm expecting that for compatibility reasons, nvidia will not change
the default behaviour - they will add the option to disable
compensation and it will be enabled by default - so our workaround will
continue to do the right thing with these newer drivers. We'll also, at
that point, be able to add a code path that sets the option instead.

--phil