[FFmpeg-devel] [PATCH] Revert "Autodetect libxcb."

[Lukasz Marek]

On 04.02.2015 21:39, Carl Eugen Hoyos wrote:
> Clément Bœsch <u <at> pkh.me> writes:
>
>> This reverts commit 23ec8db8a07467a1fbef0c79f16b33040ca63c24.
>>
>> There is no reason to enable libxcb by
>> default. This is inconsistent with all the
>> other libs (we don't do it for x11, opengl, ...)
>
> x11grab is not lgpl (that is what you meant
> with x11, no?) and opengl is a slightly
> obscure feature (but please enable auto-detection
> if you think that opengl is a system library).

I have not opinion what's better: to explicitly enable or disable a 
feature. Autodetecting has one disadvantage though, it has to work 
perfectly on every possible platform. Otherwise library may be detected, 
but may be not sufficient for some reason. So it is harder to maintain. 
Project that detect library and don't compile smells bad.
And opengl is good example of the library that may be not easy to 
autodetect.