[FFmpeg-devel] [PATCH] avcodec/hevc: reduce memory used by the SAO

[Christophe Gisquet]

Hi,

2015-02-02 13:32 GMT+01:00 Michael Niedermayer <michaelni at gmx.at>:
> On Mon, Feb 02, 2015 at 07:41:54AM +0100, Christophe Gisquet wrote:
> hmm, is there a reason not to take the original commit unchanged ?
> I was hoping to reduce the difference to openhevc so that we also
> are able to merge future changes from openhevc with few confilcts
> but maybe iam missing something

Because there are alignment requirements in our dsp, and technically,
adding another buffer (which isn't aligned) while there are already
perfectly good ones is not the best solution (memory-wise and
bookkeeping-wise).

I'd go as far as suggest openhevc to align to this version. But maybe
they have diverged too much.

Also, I don't really like merge for the sake of merging in that case,
because those are matters difficult to follow, and I prefer something
that is more logical and makes sense.

> also it seems this does not apply cleanly

OK, I took a shortcut thinking my branch wouldn't cause such an issue.
Please try the attached patch.

-- 
Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-avcodec-hevc-reduce-memory-used-by-the-SAO.patch
Type: text/x-patch
Size: 17877 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150202/deb399dc/attachment.bin>