[FFmpeg-devel] [PATCH 4/6] dv: fix weight table for 2x4x8 transform

[Michael Niedermayer]

On Sat, Jan 31, 2015 at 10:51:05PM +0100, Christophe Gisquet wrote:
> Hi,
> 
> 2014-10-30 14:49 GMT+01:00 Christophe Gisquet <christophe.gisquet at gmail.com>:
> > Hi,
> >
> > 2014-10-26 19:20 GMT+01:00 Michael Niedermayer <michaelni at gmx.at>:
> >> I took the liberty to apply the patch and fix the bug instead of
> >> leaving it open until someone succeeds writing a fate test for it
> >
> > Hi, I wonder whether this should be reverted for now (and ticket #2970
> > reopened at the same time).
> >
> > I have been checking how to produce interlaced content through the
> > encoder, and the current table produces worse results (PSNR-wise, but
> > it was big enough to not bother checking visually).
> >
> > I don't know if that's an encoder issue yet or if the decoder table is
> > still incorrect.
> 
> So I've rederived the encoder table, and I'm getting the following
> PSNR values, using tiny_psnr, on a progressive sequence from a chained
> encoding and decoding:
> Full progressive: stddev:    0.74 PSNR: 50.69 MAXDIFF:   19
> Before:           stddev:    1.43 PSNR: 44.97 MAXDIFF:   17
> This patch:       stddev:    0.76 PSNR: 50.44 MAXDIFF:   14
> 
> -- 
> Christophe

>  dvenc.c |   16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> b9e45f119febaa64d0f9e830fa00f82272c4bc59  0001-dvenc-fix-2x4x8-interlaced-weight-table.patch
> From 614a10803e964ff621e6ac27f166081699d045da Mon Sep 17 00:00:00 2001
> From: Christophe Gisquet <christophe.gisquet at gmail.com>
> Date: Fri, 30 Jan 2015 19:43:03 +0100
> Subject: [PATCH] dvenc: fix 2x4x8 (interlaced) weight table
> 
> Since the decoder has been fixed to output something similar to
> other implementations, the encoder weight table needed this fix.
> 
> Reference PSNR values on a progressive sequence (from tiny_psnr)
> from a chained encoding and decoding:
> Full progressive: stddev:    0.74 PSNR: 50.69 MAXDIFF:   19
> Before:           stddev:    1.43 PSNR: 44.97 MAXDIFF:   17
> This patch:       stddev:    0.76 PSNR: 50.44 MAXDIFF:   14

applied

thanks
[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you think the mosad wants you dead since a long time then you are either
wrong or dead since a long time.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150201/2600879e/attachment.asc>