[FFmpeg-devel] [PATCH 2/8] doc/texi2pod: use GCC implementation of @itemize

[Timothy Gu]

On Fri, Jan 24, 2014 at 3:35 AM, Stefano Sabatini <stefasab at gmail.com> wrote:
> On date Wednesday 2014-01-22 20:04:00 -0800, Timothy Gu encoded:
>> Changed to GCC r69399, 70036, & 123514. Does not change output.
>>
>> Signed-off-by: Timothy Gu <timothygu99 at gmail.com>
>> ---
>>  doc/texi2pod.pl | 8 ++++++--
>>  1 file changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/doc/texi2pod.pl b/doc/texi2pod.pl
>> index 3d1b7cd..ef2f7bc 100755
>> --- a/doc/texi2pod.pl
>> +++ b/doc/texi2pod.pl
>> @@ -249,10 +249,14 @@ INF: while(<$inf>) {
>>          and $_ = "\n=head4 $1\n";
>>
>>      # Block command handlers:
>> -    /^\@itemize\s*(\@[a-z]+|\*|-)?/ and do {
>> +    /^\@itemize(?:\s+(\@[a-z]+|\*|-))?/ and do {
>>          push @endwstack, $endw;
>>          push @icstack, $ic;
>> -        $ic = $1 ? $1 : "*";
>> +        if (defined $1) {
>> +            $ic = $1;
>> +        } else {
>> +            $ic = '*';
>> +        }
>
> This looks silly: this is disabling capturing, so $1 will be always empty
> and the following check is pointless (we never use @itemize with an
> argument, but in developer.texi).

Huh?

First, developer.texi only has @itemize @bullet.

Second, even if I changed one of the @itemize's from @bullet to
@minus, but it still works as expected.

Third, developer.texi does not generate POD/MAN output.

>
> The second change is expanding the syntax for no obvious reason. Could
> you copy paste the commit messages of the relevant GCC changes?

The commit message is painfully simple, so there is no need:

r69399 | kraai | 2003-07-15 02:24:07 -0700 (Tue, 15 Jul 2003) | 2 lines

    * texi2pod.pl: Default @itemize's parameter to @bullet.

r70036 | kraai | 2003-07-31 20:10:56 -0700 (Thu, 31 Jul 2003) | 2 lines

    * texi2pod.pl: Remove extra line.

r123514 | zack | 2007-04-04 22:46:41 -0700 (Wed, 04 Apr 2007) | 1 line

    * texi2pod.pl: Correct handling of @itemize with no argument.

This patch is just attempting to reduce delta, with no intentions to
expand syntax.

Timothy