[FFmpeg-devel] [PATCH 2/8] doc/texi2pod: use GCC implementation of @itemize

Stefano Sabatini stefasab at gmail.com
Fri Jan 24 12:35:49 CET 2014


On date Wednesday 2014-01-22 20:04:00 -0800, Timothy Gu encoded:
> Changed to GCC r69399, 70036, & 123514. Does not change output.
> 
> Signed-off-by: Timothy Gu <timothygu99 at gmail.com>
> ---
>  doc/texi2pod.pl | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/doc/texi2pod.pl b/doc/texi2pod.pl
> index 3d1b7cd..ef2f7bc 100755
> --- a/doc/texi2pod.pl
> +++ b/doc/texi2pod.pl
> @@ -249,10 +249,14 @@ INF: while(<$inf>) {
>          and $_ = "\n=head4 $1\n";
>  
>      # Block command handlers:
> -    /^\@itemize\s*(\@[a-z]+|\*|-)?/ and do {
> +    /^\@itemize(?:\s+(\@[a-z]+|\*|-))?/ and do {
>          push @endwstack, $endw;
>          push @icstack, $ic;
> -        $ic = $1 ? $1 : "*";
> +        if (defined $1) {
> +            $ic = $1;
> +        } else {
> +            $ic = '*';
> +        }

This looks silly: this is disabling capturing, so $1 will be always empty
and the following check is pointless (we never use @itemize with an
argument, but in developer.texi).

The second change is expanding the syntax for no obvious reason. Could
you copy paste the commit messages of the relevant GCC changes?
-- 
FFmpeg = Faithless & Furious Magic Political Evil Gospel


More information about the ffmpeg-devel mailing list