[FFmpeg-devel] [PATCH] Adding Cinepak encoder (attached)

[Michael Niedermayer]

On Tue, Jan 21, 2014 at 11:24:30PM +0000, u-owvm at aetey.se wrote:
> Hello,
> 
> Attaching the patches.
> 
> As for my testing the encoder is compatible with vintage players.
> 
> I perceive the quality as corresponding to windows binary encoder,
> being achieved at about/under half the bitrate.

that sounds nice but what about speed ?
in a quick test matrixbench is encoded with 0.3fps

the first patch contains no license header, the 2nd adds a BSD style
license, please clarify under which license the first patch is ?
If it is BSD then it should already contain a matching license header
otherwise some other license has to be included.

Also who is the author of the patches?
if the author of the first patch is Tomas Härdin then please set the
author of the commit correctly (git commit --amend --author ...)


[...]
> +
> +#include <assert.h>

see libavutil/avassert.h


[...]


> +    for(int v1enough = 0, v1_size = SMALLEST_CODEBOOK; v1_size <= CODEBOOK_MAX && !v1enough; v1_size <<= 2) {
> +        for(int v4enough = 0, v4_size = 0; v4_size <= v1_size && !v4enough; v4_size = v4_size ? v4_size << 2 : v1_size >= SMALLEST_CODEBOOK << 2 ? v1_size >> 2 : SMALLEST_CODEBOOK) {

some compilers dont like for(int ...


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Opposition brings concord. Out of discord comes the fairest harmony.
-- Heraclitus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140122/2501f645/attachment.asc>