[FFmpeg-devel] [PATCH 01/19] avformat/webvttdec: add support for HLS WebVTT MPEG timestamp maps

[Clément Bœsch]

On Fri, Jan 03, 2014 at 04:56:01PM +0200, Anssi Hannula wrote:
> 03.01.2014 16:49, Clément Bœsch kirjoitti:
> > On Fri, Jan 03, 2014 at 04:21:25PM +0200, Anssi Hannula wrote:
> >> WebVTT subtitle files in HLS streams contain a header to synchronize the
> >> subtitles with the MPEG TS timestamps of the HLS stream.
> >>
> >> Add an AVOption to prefer MPEG TS style timestamps generated according
> >> to the mapping header, if available.
> >>
> >> Signed-off-by: Anssi Hannula <anssi.hannula at iki.fi>
> >> ---
> >>  libavformat/webvttdec.c | 46 ++++++++++++++++++++++++++++++++++++++++++++--
> >>  1 file changed, 44 insertions(+), 2 deletions(-)
> >>
> > 
> > OK I guess...
> > 
> > I would have call the option something like "honor_timestamp_map" though,
> > but do as you please.
> 
> Well I don't have any strong opinion here, so I'll change accordingly
> since its your code.
> 
> I'm also not 100% sure if we even need an option here and could just
> always use the map if present, but I sided with caution and only use it
> when requested...

Yeah I was suggesting to not have an option, but I think that's better
that way for now. We can still change the defaults later.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140105/26c39fb2/attachment.asc>