[FFmpeg-devel] [PATCH 1/2] avutil: Add av_get_time_base{_q, }() and deprecate AV_TIME_BASE{_Q, }

[Paul B Mahol]

On 12/31/13, Hendrik Leppkes <h.leppkes at gmail.com> wrote:
> On Tue, Dec 31, 2013 at 9:00 PM, Derek Buitenhuis
> <derek.buitenhuis at gmail.com> wrote:
>> On 12/31/2013 6:24 PM, Michael Niedermayer wrote:
>>> for the AVRational returning function the nummerator is 1 always,
>>> even if the timebase would be (sanly) changed. The function should
>>> possibly instead be a static inline function that returns a 1 in that
>>> place to restore the compilers compile time knowledge of half the
>>> AVRational
>>
>> I think making it inline kind of defeats the point of being able
>> to change it. I don't think this is going to make even a remote
>> difference
>> in 'optimization'. It's a stupid micro-optimization for a function
>> which will be rarely called.
>>
>
> Similarily, its a stupid abstraction for a value which is never going
> to be changed. But hey.

Because that is best they can do.

>
> - Hendrik
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>