[FFmpeg-devel] [PATCH 2/2] pmpdec: make i unsigned, avoid undefined behavior of i++

Michael Niedermayer michaelni at gmx.at
Mon Feb 25 16:56:17 CET 2013


On Mon, Feb 25, 2013 at 08:23:05AM +0000, Paul B Mahol wrote:
> On 2/24/13, Michael Niedermayer <michaelni at gmx.at> wrote:
> > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > ---
> >  libavformat/pmpdec.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavformat/pmpdec.c b/libavformat/pmpdec.c
> > index 3b8c5f7..e0394a9 100644
> > --- a/libavformat/pmpdec.c
> > +++ b/libavformat/pmpdec.c
> > @@ -47,7 +47,7 @@ static int pmp_header(AVFormatContext *s)
> >      uint32_t index_cnt;
> >      int audio_codec_id = AV_CODEC_ID_NONE;
> >      int srate, channels;
> > -    int i;
> > +    unsigned i;
> >      uint64_t pos;
> >      int64_t fsize = avio_size(pb);
> >
> > --
> > 1.7.9.5
> >
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel at ffmpeg.org
> > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> 
> lgtm

applied
thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130225/1f436aa1/attachment.asc>


More information about the ffmpeg-devel mailing list