[FFmpeg-devel] [PATCH] lavfi/overlay: add process_command callback

[Clément Bœsch]

On Wed, Feb 20, 2013 at 12:18:12AM +0100, Stefano Sabatini wrote:
> ---
>  doc/filters.texi         |   14 ++++++++++++
>  libavfilter/vf_overlay.c |   53 ++++++++++++++++++++++++++++++----------------
>  2 files changed, 49 insertions(+), 18 deletions(-)
> 
[...]
> -    expr = over->x_expr;
> -    if ((ret = av_expr_parse(&over->x_pexpr, expr, var_names,
> -                             NULL, NULL, NULL, NULL, 0, ctx)) < 0)
> -        goto fail;
> -    expr = over->y_expr;
> -    if ((ret = av_expr_parse(&over->y_pexpr, expr, var_names,
> -                             NULL, NULL, NULL, NULL, 0, ctx)) < 0)
> -        goto fail;
> -    expr = over->enable_expr;
> -    if ((ret = av_expr_parse(&over->enable_pexpr, expr, var_names,
> -                             NULL, NULL, NULL, NULL, 0, ctx)) < 0)
> -        goto fail;
> +    if ((ret = configure_expr(&over->x_pexpr, over->x_expr, ctx) < 0) ||
> +        (ret = configure_expr(&over->y_pexpr, over->y_expr, ctx) < 0) ||
> +        (ret = configure_expr(&over->enable_pexpr, over->enable_expr, ctx) < 0))
> +        return ret;


    if ((ret = configure_expr(&over->x_pexpr, over->x_expr, ctx)) < 0 ||
        (ret = configure_expr(&over->y_pexpr, over->y_expr, ctx)) < 0 ||
        (ret = configure_expr(&over->enable_pexpr, over->enable_expr, ctx)) < 0)
        return ret;

The conditions were correct in the first place, please be careful :)

[...]

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130222/1987e76d/attachment.asc>