[FFmpeg-devel] [PATCH] lavf/matroskaenc: avoid assert failure in case of cuepoints with duplicated PTS

Stefano Sabatini stefasab at gmail.com
Tue Feb 19 00:04:16 CET 2013


On date Monday 2013-02-18 03:42:15 +0100, Michael Niedermayer encoded:
> On Sun, Feb 10, 2013 at 09:44:35PM +0100, Stefano Sabatini wrote:
[...]
> > -static int64_t mkv_write_cues(AVIOContext *pb, mkv_cues *cues, int num_tracks)
> > +static int mkv_write_cues(AVIOContext *pb, int64_t *currentpos_ptr, mkv_cues *cues, int num_tracks)
> >  {
> >      ebml_master cues_element;
> >      int64_t currentpos;
> > +    int *track_has_cue;
> >      int i, j;
> >  
> > +    if (!(track_has_cue = av_malloc(sizeof(int)*num_tracks)))
> > +        return AVERROR(ENOMEM);
> 
> isnt it sikmpler to use a field in mkv_track instead of a dynamically
> allocated array
> ?
> would also avoid the return code changes

Yes, updated.
-- 
FFmpeg = Faithful & Fantastic Mysterious Pitiless Evil God
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lavf-matroskaenc-avoid-assert-failure-in-case-of-cue.patch
Type: text/x-diff
Size: 2473 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130219/21c58ff1/attachment.bin>


More information about the ffmpeg-devel mailing list