[FFmpeg-devel] [PATCH 2/2] lavc: support subtitles charset conversion.

[Clément Bœsch]

On Fri, Jan 11, 2013 at 08:18:04PM +0100, Clément Bœsch wrote:
[...]
>   The two current patches for character encoding support, rebased on
>   master:
>     https://github.com/ubitux/FFmpeg/compare/master...sub-recode-nofilter
> 
>   The additional lavfi patches, rebased on sub-recode-nofilter:
>     https://github.com/ubitux/FFmpeg/compare/master...sub-recode
> 
> These patches are ready from my PoV (just be careful about the TODO
> version bump).
> 
> Of course, this may be discussed because of the UTF-16 insanity. My
> opinion is that for standalone text-subtitles formats we should just make
> ff_subtitles_read_chunk() and ff_get_line() support an utf16-to-utf8
> convert and be it. Yes we would loose the utf-16 encoding when
> transcoding, but I think that's really not important.
> 
> Another thing is that we don't support at all utf-16 currently in these
> demuxers, and I'm relatively against reworking them to change their
> c-string logic into a binary one.
> 
> After the sub-recode-nofilter patches, utf-16 is supported for binary
> demuxers.
> 

Ping on this.

I can rebase the two branches if needed, but I'd like some comment on
whether it sounds OK for a first version or if there are still design
issues. I admit I have a bit lost track of what was expected since last
time. Nicolas?

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130215/36d5ce14/attachment.asc>