[FFmpeg-devel] [PATCH]Fix building with --disable-everything

[Hendrik Leppkes]

On Sat, Feb 9, 2013 at 6:19 PM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
> Paul B Mahol <onemda <at> gmail.com> writes:
>
>> >> > Doesn't ticket #2253 contain all information?
>> >> > What else could be useful?
>> >>
>> >> Your explanation, compiled dump is not.
>> >> Also explanation in commit log.
>> >
>> > The explanation is that I would like to fix a
>> > regression.
>>
>> That is not explanation why you decided to make such
>> changes and not some other ones.
>
> I did not find any other change that fixes compilation
> with --disable-everything.
> (But I don't consider that an explanation for this
> patch. The relevant reason is that we have a
> regression in the build system that I would like
> to fix.)
>
> Carl Eugen
>

I agree with Paul that the changes seem rather hacky.
If something needs symbols from the h264 qpel, maybe those parts that
need it should also be put under #ifdef, instead of always building
the h264 code. The same argument should be made for all these dsputil
related things that depend on special codec data, even if that codec
is disabled.

- Hendrik