[FFmpeg-devel] [PATCH 4/4] lavd/oss: implement surround playback.

[Michael Niedermayer]

On Sun, Feb 03, 2013 at 11:09:12PM +0100, Nicolas George wrote:
> Le quintidi 15 pluviôse, an CCXXI, Michael Niedermayer a écrit :
> > I think the docs state that no flushing or delay happens if theres
> > no resampling and sufficient output bufferf size
> 
> I had missed that, that is very good news.
> 
> > can you provide a testcase for reordering of S32 that gets converted
> > to float ?
> > this should be easy to fix
> 
> I used the following command line:
> 
> ./ffmpeg_g -f s32le -ac 2 -i /dev/zero -af pan=2:c0=c1:c1=c0 -f null -t 1 -
> 
> after adding a debug av_log() in swresample.c just after the two calls to
> swri_audio_convert_alloc to dump the selected formats.

should be fixed


> 
> > about reordering packed->packed, code could be added to swr to handle
> > this case
> > Thats not meant to be an argument about doing it in alsa specific
> > code vs swr. Just that it would make sense to optimize it in swr
> 
> You know the code better than me, you are the one capable to tell whether it
> would integrate well in the code flow.

i see no major problem, just needs someone to work on it.
But it doesnt seem very high priority ATM, packed->planar->packed
for reordering has its attractiveness, as the reorder is very simple
that way

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130204/ad012ba8/attachment.asc>