[FFmpeg-devel] [PATCH 3/3] add digital cinema frame sizes

[Paul B Mahol]

On 2/3/13, Stefano Sabatini <stefasab at gmail.com> wrote:
> On date Sunday 2013-02-03 07:14:09 -0500, Dave Rice encoded:
>> On Feb 3, 2013, at 6:40 AM, Stefano Sabatini <stefasab at gmail.com> wrote:
> [...]
>> >> diff --git a/libavutil/parseutils.c b/libavutil/parseutils.c
>> >> index ca40569..4f49ef8 100644
>> >> --- a/libavutil/parseutils.c
>> >> +++ b/libavutil/parseutils.c
>> >> @@ -109,6 +109,12 @@ static const VideoSizeAbbr video_size_abbrs[] = {
>> >>     { "hd480",     852, 480 },
>> >>     { "hd720",    1280, 720 },
>> >>     { "hd1080",   1920,1080 },
>> >> +    { "2K",       2048,1080 }, /* Digital Cinema System Specification
>> >> */
>> >> +    { "2Kflat",   1998,1080 },
>> >> +    { "2Kscope",  2048, 858 },
>> >> +    { "4K",       4096,2160 }, /* Digital Cinema System Specification
>> >> */
>> >> +    { "4Kflat",   3996,2160 },
>> >> +    { "4Kscope",  4096,1716 },
>> >> };
>> >>
>> >> I left out "full container" from 2K and 4K since as you say this is a
>> >> code name, while these sizes are official according to the spec.
>> >> Dave
>> >
>> > Now my only concern are the upcased characters, currently all
>> > abbreviations are low-case (even if the "official" spelling is upcase,
>> > as in "VGA"), so I'd suggest to consider the all-lowcase variants
>> > (e.g. "4Kscope" -> "4kscope").
>> >
>> > Is that acceptable?
>>
>> Standardizing to lowercase is acceptable to me. I probably should have
>> done that in the first version of the patch.
>
> Please send an updated patch.

That is sick.