[FFmpeg-devel] Latest FFMPEG 0.9 Issues

[Aℓex Converse]

On Sun, Mar 11, 2012 at 9:25 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Sat, Dec 31, 2011 at 05:23:21PM +0100, Michael Niedermayer wrote:
>> On Fri, Dec 30, 2011 at 09:52:21PM -0800, C Chatterjee wrote:
>> >
>> > Michael:
>> >
>> > Thanks for fixing the aacdec.c bug in item 1 below in an email sent by you earlier.
>> >
>> > On item 2 I believe that checking as below:
>> >      else if (enc->codec_id == CODEC_ID_AAC && pkt->size > 2 &&
>> >                 (AV_RB16(pkt->data) & 0xfff0) == 0xfff0) {
>> >          av_log(s, AV_LOG_ERROR, "malformated aac bitstream, use -absf aac_adtstoasc\n");
>> >          return -1;
>> > may not be necessary because the 2 byte header can be at the start of a payload too.
>> > I have used this stream on a number of players - VLC, Flash and iPhone. All works.
>> > Is there a case of a player where it does not work.
>> > I comment out the lines above in flvenc.c and movenc.c and use ffmpeg as:
>> >
>> > ffmpeg -y -i xx.flv -acodec copy -vcodec -preset superfast -b:v 150k ff.flv
>> > ff.flv works fine on all players I have used.
>>
>> hmm, maybe
>> baptiste, mike or alex could comment on if this check is or is not
>> required ?
>

This can't be at the start of a non-ADTS payload. 111 is the
EndOfFrame syntax element.

> Check removed
> if someone still remembers for what case it is needed then i can put
> it back
>
> [...]
>
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Freedom in capitalist society always remains about the same as it was in
> ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin