[FFmpeg-devel] [PATCH] [matroska] Check return value of avio_seek and avoid modifying state if it fails

[Michael Niedermayer]

On Sat, Oct 22, 2011 at 07:17:02PM +0200, Michael Niedermayer wrote:
> On Sat, Oct 22, 2011 at 06:38:11PM +0200, Joakim Plate wrote:
> > On Fri, 30 Sep 2011 03:56:20 +0200, Michael Niedermayer wrote:
> > 
> > > 
> > > this doesnt look correct, index is updated in the while() and may be
> > >>= 0 and this would skip the subtitle code below
> > > 
> > 
> > Yea, looks like it. Updated patch.
> 
> >  matroskadec.c |   19 ++++++++++++-------
> >  1 file changed, 12 insertions(+), 7 deletions(-)
> > 3d813edd3b0c0439a5489927c1a181de0bba8579  0004-matroska-Check-return-value-of-avio_seek-and-avoid-m.patch
> > From 28da54d1e583d02515b57f2dbd1b3291440f7eb7 Mon Sep 17 00:00:00 2001
> > From: Joakim Plate <elupus at ecce.se>
> > Date: Sat, 22 Oct 2011 18:33:45 +0200
> > Subject: [PATCH 04/18] [matroska] Check return value of avio_seek and avoid
> >  modifying state if it fails
> 
> LGTM if tested

patch doesnt apply anymore

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120312/29e52b84/attachment.asc>