[FFmpeg-devel] [PATCH 2/2] lavfi: add tile video filter. (WIP)

[Nicolas George]

Le sextidi 16 ventôse, an CCXX, Clément Bœsch a écrit :
> For the buffer source filter, wouldn't that mean "you need to feed me more
> data before I'll be able to give you something back in the buffersink",
> or "you can feed me more data since my internal buffer can still get
> filled"?

The first one: IMHO, request frame is on the output side of the filter, it
should answer about what happens on output.

OTOH, a function, specific to vsrc_buffer, to know whether a frame can be
added, would probably be useful.

> For the buffer sink (get buffer ref), wouldn't that mean "I can't output
> you a frame ATM, but it seems there is enough data internally to do, so
> you should try again" or simply "here is a frame, but I you should try
> again since I may have some more"?

For the buffer sink, there is no output pad, so no request_frame.

> That's indeed what I proposed in another thread (see "ffmpeg -af,
> libavfilter").

I am sorry I did not read it yet, and Stefano answered before I could.

>		 Note that lavfi device doesn't use poll_frame while ffmpeg
> does, and thus I'm sure some filters behave differently.

That is my interpretation too.

Regards,

-- 
  Nicolas George