[FFmpeg-devel] [PATCH] dsputil_mmx.c: remove ff_vector128.

Måns Rullgård mans
Sat Feb 19 14:54:03 CET 2011


"Ronald S. Bultje" <rsbultje at gmail.com> writes:

> Remove ff_vector128, it is identical to ff_pb_80.
> ---
>  libavcodec/x86/dsputil_mmx.c |    5 +----
>  1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/libavcodec/x86/dsputil_mmx.c b/libavcodec/x86/dsputil_mmx.c
> index 16ad965..a5b0b3a 100644
> --- a/libavcodec/x86/dsputil_mmx.c
> +++ b/libavcodec/x86/dsputil_mmx.c
> @@ -286,9 +286,6 @@ void ff_put_pixels_clamped_mmx(const DCTELEM *block, uint8_t *pixels, int line_s
>              :"memory");
>  }
>
> -DECLARE_ASM_CONST(8, uint8_t, ff_vector128)[8] =
> -  { 0x80, 0x80, 0x80, 0x80, 0x80, 0x80, 0x80, 0x80 };
> -
>  #define put_signed_pixels_clamped_mmx_half(off) \
>              "movq    "#off"(%2), %%mm1          \n\t"\
>              "movq 16+"#off"(%2), %%mm2          \n\t"\
> @@ -313,7 +310,7 @@ void ff_put_signed_pixels_clamped_mmx(const DCTELEM *block, uint8_t *pixels, int
>      x86_reg line_skip3;
>
>      __asm__ volatile (
> -            "movq "MANGLE(ff_vector128)", %%mm0 \n\t"
> +            "movq "MANGLE(ff_pb_80)", %%mm0 \n\t"

You might want to maintain the alignment on the right-hand side there.

>              "lea (%3, %3, 2), %1                \n\t"
>              put_signed_pixels_clamped_mmx_half(0)
>              "lea (%0, %3, 4), %0                \n\t"
> -- 
> 1.7.2.1

OK

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-devel mailing list