[FFmpeg-devel] Patch for issue 1973 (targa decoder crash on corrupted file)

[Jean-Daniel Dupas]

Le 31 mai 2010 ? 12:15, M?ns Rullg?rd a ?crit :

> Kostya <kostya.shishkov at gmail.com> writes:
> 
>> On Sun, May 30, 2010 at 08:51:00PM +0200, Jean-Daniel Dupas wrote:
>>> 
>>> Le 30 mai 2010 ? 20:34, Kostya a ?crit :
>>> 
>>>> On Sun, May 30, 2010 at 07:29:03PM +0200, Jean-Daniel Dupas wrote:
>>>>> 
>>>> [...]
>>>>>> 
>>>>>> Still there is weird indentation of two spaces on some lines. And in
>>>>>> your check macro "return -1" is missing 4 spaces on indent.
>>>>> 
>>>>> Sorry for that. This time I hope it's good.
>>>> 
>>>> Still wrong in check for image size. But you're almost there.
>>> 
>>> Argh, another try. It's hard to go against the habits. I'm used to
>>> 2 spaces ;-) .
>> 
>> Please remove spaces between if (x) {, now it's inconsitent in your
>> patch (you have "if (x) {", "if(x) {" and "if(x){", I want the latter
>> and the same for "else" clause). After that it should be totally OK.
> 
> Usual FFmpeg style is "if (x) {".

targa.c already uses "if(x){", so at least, this patch is now consistent with the targa.c file.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: tga_check.patch
Type: application/octet-stream
Size: 4631 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100531/86153dd3/attachment.obj>
-------------- next part --------------



-- Jean-Daniel