[FFmpeg-devel] [PATCH] ffserver rtsp bug fixes

[Luca Abeni]

On 05/31/2010 09:38 AM, Howard Chu wrote:
> Luca Abeni wrote:
>> An additional minor comment:
>> > Index: rtpenc.c
>> > ===================================================================
>> > --- rtpenc.c (revision 23363)
>> > +++ rtpenc.c (working copy)
>> > @@ -157,6 +157,12 @@
>> > s->buf_ptr = s->buf;
>> > break;
>> }
>> > + if (st->codec->codec_id == CODEC_ID_H264&&
>> st->codec->extradata_size> 0) {
>> > + /* copied from h264.c ff_h264_decode_init() */
>> [...]
>>
>> You insert this code immediately after "switch(st->codec->codec_id) {":
>> cannot you put it in the switch, under a "case CODEC_ID_H264"?
>
> I chose not to, since currently H264 would fall into the default: case.
> I guess it's no big deal to duplicate the one relevant line from the
> default case though.

Which line? "s->buf_ptr = s->buf;"? I do not think it is needed
for H.264 (AFAIR, it is only needed when more frames can be put
in the same RTP packet)


				Luca