[FFmpeg-devel] [PATCH] ffserver rtsp bug fixes

[Howard Chu]

Luca Abeni wrote:
> An additional minor comment:
>   >  Index: rtpenc.c
>   >  ===================================================================
>   >  --- rtpenc.c	(revision 23363)
>   >  +++ rtpenc.c	(working copy)
>   >  @@ -157,6 +157,12 @@
>   >           s->buf_ptr = s->buf;
>   >           break;
>        }
>   >  +    if (st->codec->codec_id == CODEC_ID_H264&&  st->codec->extradata_size>  0) {
>   >  +        /* copied from h264.c ff_h264_decode_init() */
> [...]
>
> You insert this code immediately after "switch(st->codec->codec_id) {":
> cannot you put it in the switch, under a "case CODEC_ID_H264"?

I chose not to, since currently H264 would fall into the default: case. I 
guess it's no big deal to duplicate the one relevant line from the default 
case though.

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/