[FFmpeg-devel] [PATCH] ffmpeg.c: disable av_vsrc_buffer_add_frame() when buffer filter is disabled

[Peter Ross]

On Sun, May 30, 2010 at 02:46:40AM +0100, M?ns Rullg?rd wrote:
> Peter Ross <pross at xvid.org> writes:
> 
> > $subject
> >
> > -- Peter
> > (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
> >
> > diff --git a/ffmpeg.c b/ffmpeg.c
> > index 63f0e6b..b0dfcff 100644
> > --- a/ffmpeg.c
> > +++ b/ffmpeg.c
> > @@ -1651,7 +1651,7 @@ static int output_packet(AVInputStream *ist, int ist_index,
> >                                      &buffer_to_free);
> >          }
> >  
> > -#if CONFIG_AVFILTER
> > +#if CONFIG_AVFILTER && CONFIG_BUFFER_FILTER
> >          if (ist->st->codec->codec_type == AVMEDIA_TYPE_VIDEO && ist->input_video_filter) {
> >              // add it to be filtered
> >              av_vsrc_buffer_add_frame(ist->input_video_filter, &picture,
> 
> This doesn't work.

Okay. So what are our options?

1. require the buffer filter to always be present when libavfilter is enabled

2. decide do not use the filter system at runtime, when configure_filters() fails.
   this function may fail if any of the filters referenced by ffmpeg are disabled
   (namely: buffer, out, crop, scale)

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100530/1ab9f7d0/attachment.pgp>