[FFmpeg-devel] [PATCH] IFF: Add error checking to byterun1 decoder

[Sebastian Vater]

Sebastian Vater a ?crit :
> Ronald S. Bultje a ?crit :
>   
>> Hi,
>>
>> On Wed, May 26, 2010 at 3:20 PM, Sebastian Vater
>> <cdgs.basty at googlemail.com> wrote:
>>   
>>     
>>> -    for (x = 0; x < dst_size && buf < buf_end;) {
>>> -        unsigned length;
>>> -        const int8_t value = *buf++;
>>> -        if (value >= 0) {
>>> -            length = value + 1;
>>> -            memcpy(dst + x, buf, FFMIN3(length, dst_size - x, buf_end - buf));
>>> -            buf += length;
>>> -        } else if (value > -128) {
>>> -            length = -value + 1;
>>> -            memset(dst + x, *buf++, FFMIN(length, dst_size - x));
>>> -        } else { // noop
>>> -            continue;
>>> -        }
>>> -        x += length;
>>> +    if (buf < buf_end) {
>>> +        do {
>>> +            const int8_t value = *buf++;
>>>     
>>>       
>> Your patch now mixes indentation and functional changes.
>>   
>>     
>
> Fixed. Reindent patch will follow...
>   

WTF! Why are the changes in the decode_frame_byterun1 missing!?!?!?

Anyway, readded them and therefore fixed!

-- 

Best regards,
                   :-) Basty/CDGS (-:

-------------- next part --------------
A non-text attachment was scrubbed...
Name: iff-byterun1-error.patch
Type: text/x-patch
Size: 4249 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100526/e06e2c4a/attachment.bin>