[FFmpeg-devel] [PATCH] IFF: Add error checking to byterun1 decoder

[Sebastian Vater]

Ronald S. Bultje a ?crit :
> Hi,
>
> On Wed, May 26, 2010 at 11:24 AM, Sebastian Vater
> <cdgs.basty at googlemail.com> wrote:
>   
>> Ronald S. Bultje a ?crit :
>>     
>>> Then in the loop, you can add more if (buf>=end) break; checks, and at
>>> the end of the function you can add the actual error message which is
>>> triplicated throughout the loop now (if (buf >= end) { av_log();
>>> return error; }
>>>       
>> That sounds much better, indeed, yes.
>> Another possibility would be though to change the error messages in each
>> (i.e. make them more detailed), what do you think of this?
>>     
>
> I'm no sure how useful it is for the user to know wha part failed. In
> all cases, it means the file cannot be decoded.
>   

Ok, so I fixed it the first way. Happy reviewing again! ;-)

-- 

Best regards,
                   :-) Basty/CDGS (-:

-------------- next part --------------
A non-text attachment was scrubbed...
Name: iff-byterun1-error.patch
Type: text/x-patch
Size: 4373 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100526/c8e8d9eb/attachment.bin>